Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Julien Salleyron to maintainers #1790

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Add Julien Salleyron to maintainers #1790

merged 1 commit into from
Jun 27, 2017

Conversation

emilevauge
Copy link
Member

@emilevauge emilevauge commented Jun 27, 2017 •
edited
Loading

Description

This PR adds @juliens to the maintainer team.

welcome

nmengin
nmengin approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕶

ldez
ldez approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

timoreimann
timoreimann approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing, but okay ;-)

@ldez ldez force-pushed the emilevauge-add-juliens-maintainers branch from 0e42509 to 8b6a9a3 Compare June 27, 2017 13:15
dtomcej
dtomcej approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

errm
errm approved these changes Jun 27, 2017
View reviewed changes
Copy link
Contributor

@errm errm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez modified the milestone: 1.4 Jun 27, 2017
SantoDE
SantoDE approved these changes Jun 27, 2017
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

Welcome!

@ldez ldez force-pushed the emilevauge-add-juliens-maintainers branch from 8b6a9a3 to 8fd1c80 Compare June 27, 2017 19:17
@ldez ldez merged commit efb6714 into master Jun 27, 2017
@ldez ldez deleted the emilevauge-add-juliens-maintainers branch June 27, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@errm errm errm approved these changes

@juliens juliens juliens approved these changes

@timoreimann timoreimann timoreimann approved these changes

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
9 participants
@emilevauge @vdemeester @errm @juliens @timoreimann @SantoDE @ldez @nmengin @dtomcej