Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-compose PRs are not merged - shortterm version available #742

Closed
maurerle opened this issue Aug 7, 2023 · 4 comments
Closed

podman-compose PRs are not merged - shortterm version available #742

maurerle opened this issue Aug 7, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@maurerle
Copy link
Contributor

maurerle commented Aug 7, 2023

Is your feature request related to a problem? Please describe.
Somehow it is frustrating, that a lot Pull-Requests of podman-compose are not merged without comments, even though they provide additional value.
I do know that open-source can be hard, peoples life changes or people lose interest in things they used to maintain.
So we should always be respectful with that!

Describe the solution you'd like
I would like to have a version in the containers org which addresses the fixes provided by the community or gives responses what has to be changed for them to be integrated.

Describe alternatives you've considered
Until this happens, I merged pull requests which are not deprecated or break the single file installation into my devel branch:
https://github.com/maurerle/podman-compose

I would not like to keep maintaining this, but for now, this is a working solution which might be interesting for others in need as well.
To install, run:
curl -o /usr/local/bin/podman-compose https://raw.githubusercontent.com/maurerle/podman-compose/devel/podman_compose.py && chmod +x /usr/local/bin/podman-compose

Additional context
@muayyad-alsadi Thank you for this tool, which makes migrating to podman quite easy on typical development installations!

@maurerle maurerle added the enhancement New feature or request label Aug 7, 2023
@muayyad-alsadi
Copy link
Collaborator

it's not that I lost interest
some times the PR is supposed to solve something small but instead of fixing that simple thing they change every aspect of the file (ex. split the single .py into many files or change shabang or ...)

some times the change is big and the affected area is large
it fixes a case and break others (to this day we are suffering consequences of merging coloring output using sed, which is not available on windows and swallows last line of output if it does not have newline)

another example, some people like putting all containers in a pod, others hate it.
sometimes it will work for most cases but breaks less common but standard cases (ex. when putting the entire stack in a single pod, having a custom different hostname for each container is not allowed by default ...etc)

sometimes the fix uses threads ..etc.
sometimes it makes podman-compose active in the background (my vision to podman-compose, just exec and fork podman), that's why I suggested some changes to podman

how to go from here?
maybe podman team suggest names to become co-maintainers as I'm very busy with my full-time job.

@maurerle
Copy link
Contributor Author

maurerle commented Oct 4, 2023

Hello @muayyad-alsadi - I understand, that PRs which are against the philosophy of this project (single process, single file) do not get merged.
However, improvements, adjustments to podman/docker features are needed and are often just small fixes.
The situation somehow did not improve at all.
I updated my devel branch to include useful fixes from latest PRs:
devel...maurerle:podman-compose:devel
(mostly using wget to download a patchset and apply it using git am --3way file.patch)

Issues and PRs are created for the same things, as some small issues do not get merged (see #771 and #761).

And the PR to reduce logging output #741 did not get any feedback yet.

I really would not like if it is needed to create a maintained fork of this project.

@p12tic
Copy link
Collaborator

p12tic commented Jun 27, 2024

Pull requests are now merged to podman-compose, we can close this issue.

@p12tic p12tic closed this as completed Jun 27, 2024
@maurerle
Copy link
Contributor Author

Thank you very much for taking care of this @p12tic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants