Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore search coingecko if query empty #1253

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: ignore search coingecko if query empty #1253

merged 1 commit into from
Nov 28, 2023

Conversation

trkhoi
Copy link
Contributor

@trkhoi trkhoi commented Nov 28, 2023

What's this PR does ?

e.g: Update API get balances

Which UI commands affect by this change ?

e.g: /balances

DoD

  • Is it public API in documentation? Any docs update required ?
  • Does it change the response data shape ?
  • Is it require to update the mock data in preview ?
  • Include the sample call / example in this PR

@trkhoi trkhoi merged commit f69c62f into develop Nov 28, 2023
1 of 2 checks passed
@trkhoi trkhoi deleted the fix/ignore-search-coingecko-if-query-empty branch November 28, 2023 06:10
jphuc96 pushed a commit that referenced this pull request Nov 28, 2023
@semantic-release-bot
chore(release): 6.23.0 [skip ci]
d41f7c7 
# [6.23.0](v6.22.12...v6.23.0) (2023-11-28)

### Bug Fixes

* add sentry service layer ([#1247](#1247)) ([3242d19](3242d19))
* add theme transaction ([#1248](#1248)) ([d17f4a3](d17f4a3))
* add theme transaction v2 ([#1249](#1249)) ([4c7a6f2](4c7a6f2))
* handle coingecko id not found ([#1252](#1252)) ([7668a5b](7668a5b))
* handle retry getting gas tracker ([#1254](#1254)) ([1a46c54](1a46c54))
* ignore search coingecko if query empty ([#1253](#1253)) ([f69c62f](f69c62f))

### Features

* add method to get jetton balance ([5b0bf50](5b0bf50))
@jphuc96
Copy link
Collaborator

jphuc96 commented Nov 28, 2023

🎉 This PR is included in version 6.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trkhoi @jphuc96