Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: grpc-web-text wire format support #143

Open
bhainesva opened this issue Oct 16, 2024 · 1 comment · May be fixed by #150
Open

Feature Request: grpc-web-text wire format support #143

bhainesva opened this issue Oct 16, 2024 · 1 comment · May be fixed by #150
Assignees
@emcfarlane

Comments

@bhainesva
Copy link

Users of grpc-web clients that want to support streaming are currently required to use the grpc-web-text wire format (https://github.com/grpc/grpc-web?tab=readme-ov-file#streaming-support).

On the server side this format is supported by proxies like Envoy or Improbable's grpcwebproxy.

If Vanguard supported this format it would make it easier for grpc-web users to gradually transition to Connect by allowing them to first switch their proxy to Vanguard and then incrementally update their frontend clients, without losing server side streaming support for clients that aren't yet migrated.

Request originated in this slack thread: https://bufbuild.slack.com/archives/CRZ680FUH/p1729008888312809
@emcfarlane emcfarlane self-assigned this Oct 16, 2024
@emcfarlane
Copy link
Collaborator

Hey @bhainesva thanks for reporting. I'll pick up and have a look at adding support later this week. Currently we don't support grpc-web-text across any of the connect implementations. Adding support in vanguard-go does make sense for this use case and as a first implementation. Eventually we would look at also adding in coverage in the conformance test suite.

@emcfarlane emcfarlane linked a pull request Nov 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emcfarlane emcfarlane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for gRPC-Web text encoding connectrpc/vanguard-go
2 participants
@emcfarlane @bhainesva