Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs example for interceptor is wrong #333

Closed
jhump opened this issue Jul 28, 2022 · 1 comment
Closed

Docs example for interceptor is wrong #333

jhump opened this issue Jul 28, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jhump
Copy link
Member

jhump commented Jul 28, 2022

The example in the docs, https://connect.build/docs/go/streaming#an-example, shows a logging interceptor implementation. But it does not implement the right interface. It implements a prior shape of the interceptor interface, from before #316.
@jhump jhump added the bug Something isn't working label Jul 28, 2022
@akshayjshah
Copy link
Member

Yikes! Fixed in https://github.com/bufbuild/connect-docs/pull/92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akshayjshah @jhump