Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockito dependency needs to be test scoped #375

Closed
wonmo01 opened this issue Aug 10, 2022 · 3 comments · Fixed by #376
Closed

Mockito dependency needs to be test scoped #375

wonmo01 opened this issue Aug 10, 2022 · 3 comments · Fixed by #376
Labels
verified bug Something isn't working

Comments

@wonmo01
Copy link
Contributor

wonmo01 commented Aug 10, 2022

From parent pom.xml, mockito dependency is not scoped as test.
https://github.com/confluentinc/parallel-consumer/blob/master/pom.xml#L335-L339

        <dependency>
            <groupId>org.mockito</groupId>
            <artifactId>mockito-junit-jupiter</artifactId>
            <version>${mockito.version}</version>
<!--            <scope>test</scope> <<<<<<<<<<<< MISSING --> 
        </dependency>
@wonmo01
Copy link
Contributor Author

wonmo01 commented Aug 10, 2022

@astubbs I am not sure if this is intentional, but is there any chance this can be changed to test scoped?

@astubbs
Copy link
Contributor

astubbs commented Aug 16, 2022

Yes, that needs fixing

@astubbs astubbs changed the title mockito dependency needs to be test scoped Mockito dependency needs to be test scoped Aug 16, 2022
@astubbs astubbs added the verified bug Something isn't working label Aug 16, 2022
@astubbs astubbs linked a pull request Aug 16, 2022 that will close this issue
@astubbs
Copy link
Contributor

astubbs commented Aug 16, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants