Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix using absolute path in include directories #3329

Merged
merged 1 commit into from
Apr 6, 2021
Merged

cmake: Fix using absolute path in include directories #3329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ if(MINGW)
endif(MINGW)

# Support '#include <rdkafka.h>'
target_include_directories(rdkafka PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}>")
target_include_directories(rdkafka PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}> $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)
target_compile_definitions(rdkafka PUBLIC ${rdkafka_compile_definitions})
if(RDKAFKA_BUILD_STATIC)
target_compile_definitions(rdkafka PUBLIC LIBRDKAFKA_STATICLIB)
Expand Down Expand Up @@ -207,13 +207,13 @@ endif()

if(WITH_ZLIB)
find_package(ZLIB REQUIRED)
target_include_directories(rdkafka PUBLIC ${ZLIB_INCLUDE_DIRS})
target_include_directories(rdkafka PRIVATE ${ZLIB_INCLUDE_DIRS})
target_link_libraries(rdkafka PUBLIC ZLIB::ZLIB)
endif()

if(WITH_ZSTD)
target_link_libraries(rdkafka PUBLIC ${ZSTD_LIBRARY})
target_include_directories(rdkafka PUBLIC ${ZSTD_INCLUDE_DIR})
target_link_libraries(rdkafka PRIVATE ${ZSTD_LIBRARY})
target_include_directories(rdkafka PRIVATE ${ZSTD_INCLUDE_DIR})
message(STATUS "Found ZSTD: ${ZSTD_LIBRARY}")
endif()

Expand All @@ -222,12 +222,12 @@ if(WITH_SSL)
if(NOT TARGET bundled-ssl)
message(FATAL_ERROR "bundled-ssl target not exist")
endif()
target_include_directories(rdkafka BEFORE PUBLIC ${BUNDLED_SSL_INCLUDE_DIR})
target_include_directories(rdkafka BEFORE PRIVATE ${BUNDLED_SSL_INCLUDE_DIR})
target_link_libraries(rdkafka PUBLIC ${BUNDLED_SSL_LIBRARIES})
add_dependencies(rdkafka bundled-ssl)
else()
find_package(OpenSSL REQUIRED)
target_include_directories(rdkafka PUBLIC ${OPENSSL_INCLUDE_DIR})
target_include_directories(rdkafka PRIVATE ${OPENSSL_INCLUDE_DIR})
target_link_libraries(rdkafka PUBLIC OpenSSL::SSL OpenSSL::Crypto)
get_target_property(OPENSSL_TARGET_TYPE OpenSSL::SSL TYPE)
if(OPENSSL_CRYPTO_LIBRARY MATCHES "\\.a$")
Expand All @@ -244,7 +244,7 @@ find_package(Threads REQUIRED)
target_link_libraries(rdkafka PUBLIC Threads::Threads)

if(WITH_SASL_CYRUS)
target_include_directories(rdkafka PUBLIC ${SASL_INCLUDE_DIRS})
target_include_directories(rdkafka PRIVATE ${SASL_INCLUDE_DIRS})
target_link_libraries(rdkafka PUBLIC ${SASL_LIBRARIES})
endif()

Expand All @@ -253,7 +253,7 @@ if(WITH_LIBDL)
endif()

if(WITH_LZ4_EXT)
target_include_directories(rdkafka PUBLIC ${LZ4_INCLUDE_DIRS})
target_include_directories(rdkafka PRIVATE ${LZ4_INCLUDE_DIRS})
target_link_libraries(rdkafka PUBLIC LZ4::LZ4)
endif()

Expand Down