Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Error | test_verify_sig_and_extract_payload panics due to address align #136

Closed
Xynnn007 opened this issue Apr 7, 2023 · 3 comments
Closed

Comments

@Xynnn007
Copy link
Member

Xynnn007 commented Apr 7, 2023

nightly error

failures:

---- signature::mechanism::simple::verify::tests::test_verify_sig_and_extract_payload stdout ----
thread 'signature::mechanism::simple::verify::tests::test_verify_sig_and_extract_payload' panicked at 'misaligned pointer dereference: address must be a multiple of 0x4 but is 0x7f16dc000b85', /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sha1collisiondetection-0.2.6/lib/sha1.rs:320:27
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@Xynnn007
Copy link
Member Author

This error is corresponded to dependency sequoia-openpgp in nightly rust. And it is important when using simple signing. Two possible ways to resolve:

  1. replace sequoia-openpgp with pgp. The pro is that pgp is a purely rust (without ring) one with less size, while sequoia-openpgp depends on openssl
  2. Wait for the fix of sequoia-openpgp in upstream, and temporarily ignore the nightly error

cc the writer of simple signing @jialez0 @arronwy

@wainersm
Copy link
Member

Hi @Xynnn007 @jialez0 @arronwy ,

I'd like to understand if this issue has impact on the upcoming CoCo 0.5.0 release. If it has no impact, then I will ignore the nightly CI failure on #138 . Thanks!

@arronwy
Copy link
Member

arronwy commented Apr 12, 2023

Hi @Xynnn007 @jialez0 @arronwy ,

I'd like to understand if this issue has impact on the upcoming CoCo 0.5.0 release. If it has no impact, then I will ignore the nightly CI failure on #138 . Thanks!

Hi @wainersm , this issue will not block CoCo 0.5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants