Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optional dependencies for gmpy2 and fastcache #15

Open
asmeurer opened this issue Apr 7, 2019 · 4 comments
Open

Use optional dependencies for gmpy2 and fastcache #15

asmeurer opened this issue Apr 7, 2019 · 4 comments

Comments

@asmeurer
Copy link
Member

asmeurer commented Apr 7, 2019

gmpy and fastcache should be optional dependencies. I believe these are supported by conda now. It should make it so that they get installed with sympy, but they can be conda removed without also removing sympy.

Also I don't know why setuptools is a run dependency of sympy. It shouldn't be needed.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 7, 2019

Also I don't know why setuptools is a run dependency of sympy. It shouldn't be needed.

#13 (comment)

@asmeurer
Copy link
Member Author

asmeurer commented Apr 8, 2019

We should look into that. The conda entry points ought to work just fine on Windows.

@asmeurer asmeurer mentioned this issue Apr 10, 2019
@asmeurer asmeurer mentioned this issue Oct 31, 2019
@isuruf
Copy link
Member

isuruf commented Oct 31, 2019

There's no support for optional dependencies in conda. There's run_constrained which says that if a package is installed in the environment, the version has to satisfy the constraint. i.e. we can say sympy needs gmpy2>=2.0.8 if gmpy2 is installed, but installing sympy will not install gmpy2.

@asmeurer
Copy link
Member Author

I guess I misunderstood the feature. I'd like something where it tries to install the dependency if it can, but if it isn't available or satisfiable to install it, it just skips it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants