Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license informaton about vendored packages #34

Closed
hmaarrfk opened this issue Jan 18, 2021 · 6 comments
Closed

Add license informaton about vendored packages #34

hmaarrfk opened this issue Jan 18, 2021 · 6 comments

Comments

@hmaarrfk
Copy link
Contributor

In #7 (comment) @seemethere had offered to help with some packaging work for conda-forge.

@isuruf suggested that we work on #7 (comment)

@seemethere, thanks for the offer. One task you could help with is a way to collect the licenses/copyright notices of the third party dependencies to comply with their license terms.

I'm creating this issue so we can close the original GPU issue.

@hmaarrfk hmaarrfk mentioned this issue Jan 18, 2021
@rgommers
Copy link

Typically there's a LICENSE or LICENSE.TXT or COPYING file in each subdirectory under third_party. It would be useful to specify what's actually needed here (format of metadata) - maybe link to a good example for another package?

@jaimergp
Copy link
Member

This is what we did for OpenMM.

@isuruf
Copy link
Member

isuruf commented Jan 18, 2021

What we need is a way to get a single license file that concatenates all of the license files.

@rgommers
Copy link

What we need is a way to get a single license file that concatenates all of the license files.

That should normally be present in an sdist or wheel too - I'd consider it a bug if that's missing. Wheels don't contain the correct info, and sdists aren't present at all on PyPI (different issue and probably on purpose, but also questionable - I'll file some issues).

@isuruf
Copy link
Member

isuruf commented Jan 18, 2021

That should normally be present in an sdist or wheel too

It's not available and not available in the conda packages that pytorch distributes either. The only copyright notices found are those of pytorch sources and caffe2 sources and completely ignore the copyright notices of dozens of third party modules used.

@rgommers
Copy link

This is now available: https://github.com/pytorch/pytorch/blob/master/third_party/LICENSES_BUNDLED.txt. That file is included in the pytorch 1.8.0 wheels as well.

@isuruf isuruf closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants