Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to avoid string optimization #66

Closed
wants to merge 2 commits into from
Closed

Add flags to avoid string optimization #66

wants to merge 2 commits into from

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Mar 5, 2022 •
edited
Loading

Fixes: #63

Questions:

  • Do we need this in the FFLAGS. I assumed so.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@hmaarrfk hmaarrfk requested review from beckermr and isuruf as code owners March 5, 2022 14:21
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Mar 5, 2022

@conda-forge-admin, please rerender

@beckermr
Copy link
Member

beckermr commented Mar 5, 2022

I can't recall if cflags gets reused for the other vars and so we only need this there.

I think @isuruf might have insight or we can consult the activation scripts.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Mar 5, 2022

A quick search of CFLAGS in https://github.com/hmaarrfk/ctng-compiler-activation-feedstock/blob/fno-merge-constants/recipe/activate-gfortran.sh#L88 reveals nothing.

@beckermr
Copy link
Member

beckermr commented Mar 5, 2022

Right except that the Fortean compiler requires the c one maybe. In any case, duplicated flags are ugly but shouldn’t break anything I think.

@hmaarrfk hmaarrfk marked this pull request as draft March 5, 2022 15:02
@hmaarrfk hmaarrfk closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermr beckermr Awaiting requested review from beckermr beckermr is a code owner

@isuruf isuruf Awaiting requested review from isuruf isuruf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -fno-merge-constants to default flags?
3 participants
@hmaarrfk @conda-forge-linter @beckermr