-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot-fix packages using NumPy to require <2 ? #516
Comments
I opened #712
For packages compiling against numpy, we've had a run-export for 2 years (conda-forge/numpy-feedstock@bca0916), so this should not be an issue. The problem is that feedstocks with a run-only dependence will do stuff like We could address this in the piggyback, but it's not even clear to me that we'd need to change it, if the package builds successfully against 2.0. |
There isn't a huge amount left to do here after #728 I think. However, obviously more packages can get added in numpy/numpy#26191, and also some packages which are currently missing a known lowest numpy 2.0-compatible version should be updated in the patch_yaml as those versions become known, see: conda-forge-repodata-patches-feedstock/recipe/patch_yaml/numpy2_unknown_lower_bound.yaml Lines 1 to 6 in 28be10e
For those reasons, I suggest to keep the issue open. |
SGTM! I am going to draft an announcement explaining where to put patches and what we did. |
Should we roll that announcement into a general NumPy 2 announcement? Repodata patching is presumably only on of a few things for NumPy 2 users & maintainers will care about |
I feel like we can close this issue now right? |
As brought up in issue ( conda-forge/scikit-learn-feedstock#227 ) ( in particular comment: conda-forge/scikit-learn-feedstock#227 (comment) ), for old packages we may not have
numpy
dependencies inrun
correctly constrained to ensurenumpy
2
isn't pulled in by accident. Some proposed next steps:numpy
upper bounds are undefined or too loosenumpy
constraint (if that hasn't already happened)Please suggest other steps or revise existing ones
cc @conda-forge/core
The text was updated successfully, but these errors were encountered: