Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Load-Balancing config to enable more settings. #79

Closed
JohnPreston opened this issue May 26, 2020 · 1 comment · Fixed by #94
Closed

Refactor the Load-Balancing config to enable more settings. #79

JohnPreston opened this issue May 26, 2020 · 1 comment · Fixed by #94
Assignees
Labels
enhancement New feature or request

Comments

@JohnPreston
Copy link
Member

Is your feature request related to a problem? Please describe.
I want to be able to define extra settings for the ALB or NLB which points to my container.
Instead of using booleans for use_alb / use_nlb, I would prefer to have a configuration object, containing a variable lb_type value set to network or application.

Describe the solution you'd like

services:
  serviceA:
    configs:
      network:
        ingress:
          lb_type: application
          acm: use::blah # example of extra settings.

Additional context

@JohnPreston JohnPreston added the enhancement New feature or request label May 26, 2020
@JohnPreston JohnPreston self-assigned this May 26, 2020
@JohnPreston JohnPreston linked a pull request Jun 28, 2020 that will close this issue
@JohnPreston
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant