Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-secrets to support JSON Key and version #232

Closed
JohnPreston opened this issue Nov 6, 2020 · 0 comments · Fixed by #256
Closed

x-secrets to support JSON Key and version #232

JohnPreston opened this issue Nov 6, 2020 · 0 comments · Fixed by #256
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JohnPreston
Copy link
Member

JohnPreston commented Nov 6, 2020

Is your feature request related to a problem? Please describe.
Fargate now supports JSON Key for secrets in secrets manager.
I want the ability to specify the JSON key to use for a specific env var.

Describe the solution you'd like

secrets:
  BOOTSTRAP_URL:
    x-secrets:
      Name: /path/to/secret
      JsonKey: BootstrapUrl
  SASL_JAAS_CONFIG:
    x-secrets:
      Name: /path/to/secret
      JsonKey: SaslJaasConfig

Describe alternatives you've considered
Inline key and version possibly.

secrets:
  BOOTSTRAP_URL:
    x-secrets:
      Name: /path/to/secret:BootstrapUrl
  SASL_JAAS_CONFIG:
    x-secrets:
      Name: /path/to/secret:SaslJaasConfig

Additional context
https://aws.amazon.com/about-aws/whats-new/2020/11/aws-fargate-for-amazon-ecs-launches-features-focused-on-configuration-and-metrics/

@JohnPreston JohnPreston added the enhancement New feature or request label Nov 6, 2020
@JohnPreston JohnPreston self-assigned this Nov 6, 2020
@JohnPreston JohnPreston added this to the v0.9.0 milestone Nov 10, 2020
@JohnPreston JohnPreston linked a pull request Nov 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant