Enable Code Analysis

[smudge202]

Compose doesn't conform to CA

[smudge202]

Moving this back to v0.1.5-beta because it does not block ongoing development of consumer software.

[ghost]

I can take a look at in the next few days when I feel a bit better. Just lettme know which branch to fork from

[smudge202]

dev

[smudge202]

Be worth investigating whether this is an sdk package or an analysis package: https://www.nuget.org/packages/Microsoft.CodeAnalysis/1.0.0-rc3

[ghost]

This might be what we actually want: https://github.com/DotNetAnalyzers/StyleCopAnalyzers - more research to come later. Depends on what level of CA is required, probably best to discuss that first. //cc @mattridgway

[ghost]

Progress update:

I believe the correct package is actually Microsoft.CodeAnalysis.Analyzers. In order to get them to run properly on my machine, I had to create a seperate project and pull in the same code. That said, I have some type load exceptions from one or more of the analysers. For the ones that it did manage to do, we just need to mark the Exceptions are serializable. I've not actioned this yet as we still have the pending discussion: https://github.com/4Com/compose-remoting/issues/18

[herecydev]

In the latest ASP.NET community standup there was some talk about code analysis coming in the future. They've obviously got plans about how they want it. Right now it's a bit of a mess; different authors producing lots of packages. Not sure what the "correct" way of doing things is.