-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracting Signal to Noise data from Raw Files #130
Comments
Hi @GeorgWa , |
Thanks a lot for the fast reply! |
Just a quick update. I forked the repository and was able to add the data raw noise data to the mzML output. If you are interested I can add this functionality with a pull request. Please let me know:
Is this something I should discuss with the HUPO-PSI team? Cheers, |
Do you suppose that the noise array should have the same units as the intensity array? |
Yes, I expect them to have the same units. Its interesting though, the term I used, id: I am also not sure if the noise array I use is compatible with the m/z array if no centroiding is performed. I have not found a way with the Thermo RawFileReader to get Noise for uncentroided spectra. Let me know what you would suggest. |
@GeorgWa Great, thank you for active participation. You are welcome to submit PR with the changes you have made, they will be merged into the next release with the other pending changes. Since there aren't any specific tests for signal-to-noise, you can just make sure the tests in ThermoRawFileParserTest solution work. The later requires setting up NUnit - it is sometimes a bit tricky, thus, it is up to you if you are willing to spend time for that. I will run the tests before the merge. Noise, baseline, charge, and resolution data are only present, for FTMS scans and only for centroids, these properties (to the best of my knowledge) are pre-calculated on the instrument side and stored to a RAW file directly. For profile data and/or non-FTMS scans it is not possible to retrieve these through their library (again, to the best of my knowledge) - these only contain m/z and intensity data. There is, however, a general method
I am a bit puzzled what is the use of I agree that noise and baseline should have the same dimensions as intensity, for example, detector counts; signal-to-noise, however, should be dimensionless, since it is a ratio. Do you think it would be relevant to have an option to input signal-to-noise directly to mzML, rather than an additional noise array? It can be a substitute of intensity array, it does not seem to broke mzML specs (http://www.peptideatlas.org/tmp/mzML1.1.0.html), there should be at least 2 |
@caetera thanks for the recommendations regarding the testing, I will check this out. I compared all ways of accessing the noise data and Currently I get all three arrays from the I introduced the following parameter which controls the output: If this parameter is set, the three different binaryDataArrays (Noises/Masses/Baselines) ar added to the binaryDataArrayList in every spectrum. Note that the If the
|
Yes, If it is fine for your needs that noise data is going to be always "centroided", i.e. will be present only at certain subset of m/z values even for profile scans, then the current implementation should work fine. I think, though, it is necessary to describe this peculiarity in the documentation (I can do it before making a release). If I understand it correctly, Does not |
I wonder if we really know what the units of But in any case, it is reasonable to add the same set of has_units to these terms that we have for others. I will get it on the docket. |
@edeutsch I'm also not sure about @caetera Its definetly an option to skip |
@edeutsch good, thank you. I believe baseline is a kind of zero-level intensity and thus should have the same dimension, but I am not 100% sure as well. @GeorgWa I have asked Jim Shofstahl - the developer of RawFileReader in Thermo if it is possible to get the noise data for profile and low resolution scans. Let's see what will be his response. I think then it is easier to have both |
Here is the reply of Jim:
|
@caetera Thanks for forwarding the answer from Jim! Id would be great if you can update me if you hear anything else about noise for profile data. |
Hi @GeorgWa, |
Hi @GeorgWa |
Merged after fixing |
Hi,
I have used the ThermoRawFileParser for some time now and I'm very happy with the Software!
Is there an option to include the signal to noise data in the mzML as defined in the mzML standard?
Best,
Georg
The text was updated successfully, but these errors were encountered: