Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of reusable workflows for ci #279

Open
mcbarton opened this issue May 14, 2024 · 13 comments
Open

Use of reusable workflows for ci #279

mcbarton opened this issue May 14, 2024 · 13 comments
Labels
ci CI workflows to-fix

Comments

@mcbarton
Copy link
Collaborator

mcbarton commented May 14, 2024

Now that the ci in the repos are approximately the same, we are now in a position to start replacing it with reusable workflows from a central repo. @vgvassilev could you make a repo for these workflows, and then change the settings of that repo according to what is described in the below link

https://github.blog/2022-02-10-using-reusable-workflows-github-actions/

After this has been done I will begin the process of replacing parts of the ci in this repo (and others) bit by bit with the workflows in this new repo. That way the ci is all the repos should then stay upto date with each other.

@vgvassilev
Copy link
Contributor

Can you propose a repo name?

@mcbarton
Copy link
Collaborator Author

Can you propose a repo name?

I'd just go with something simple like 'Reusable-Workflows' or 'Reusable-Actions' . That way its clear to anyone who clicks on the organisation what it contains.

@aaronj0
Copy link
Collaborator

aaronj0 commented May 14, 2024

Looks cool! Does this allow us write to a single workflow for the CI that can be used as the main workflow for the three cppyy repo and as a subworkflow within InterOp? That would be amazing

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 14, 2024

Looks cool! Does this allow us write to a single workflow for the CI that can be used as the main workflow for the three cppyy repo and as a subworkflow within InterOp? That would be amazing

@maximusron You'll be able to write to worflows in this new repo, and all the repos will use it accordingly. There will be no need in future to update it in all the repos separately. The cppyy/CppInterOp repos will call the workflows from this new repo.

@aaronj0
Copy link
Collaborator

aaronj0 commented May 14, 2024

Yep I understand that, my question was more about the way we pull these workflows and how we choose to discretize their parts. For example up until the Build and Test CppInterOp will differ in cppyy repos from the CppInterOp repos. The cppyy installation + testing will remain common. So we need to break it into reusable parts that make the most sense. For example
image

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 14, 2024

Yep I understand that, my question was more about the way we pull these workflows and how we choose to discretize their parts. For example up until the Build and Test CppInterOp will differ in cppyy repos from the CppInterOp repos. The cppyy installation + testing will remain common. So we need to break it into reusable parts that make the most sense. For example image

@maximusron How you would like to see the workflow broken down into smaller chunks its probably more of a discussion for you and @vgvassilev to discuss (Alternatively I could also break it down into what I think are small useful chunks, and you can make suggestions for improvements as I do the transition). In the case where you want a Valgrind check, documentation, coverage, etc this can be done with workflow inputs. I'll try and implement the way you choose, and cc you if I run into any difficulties.

@vgvassilev
Copy link
Contributor

Can you propose a repo name?

I'd just go with something simple like 'Reusable-Workflows' or 'Reusable-Actions' . That way its clear to anyone who clicks on the organisation what it contains.

Do we envision anybody else beyond our org to use these actions? If so, we need to have some sort of prefix?

@mcbarton
Copy link
Collaborator Author

Can you propose a repo name?

I'd just go with something simple like 'Reusable-Workflows' or 'Reusable-Actions' . That way its clear to anyone who clicks on the organisation what it contains.

Do we envision anybody else beyond our org to use these actions? If so, we need to have some sort of prefix?

@vgvassilev I could be wrong, but I don't believe anybody outside the organisation will be able to make use of this repo.

@mcbarton
Copy link
Collaborator Author

image

@vgvassilev This part of the link I put in the issue says you set it so it cannot be used outside the organisation.

@vgvassilev
Copy link
Contributor

I meant if we expect the workflows to be generic enough so that somebody else outside of our org to find them useful and possibly use them.

@mcbarton
Copy link
Collaborator Author

I meant if we expect the workflows to be generic enough so that somebody else outside of our org to find them useful and possibly use them.

@vgvassilev There may be some workflows generic enough for others to use them (for example I can probably make the llvm cache one generic enough). I suspect the majority at least at first will specific to the organisation. I don't know what name to put for the repo in these circumstances.

@aaronj0 aaronj0 added the ci CI workflows label May 16, 2024
@vgvassilev
Copy link
Contributor

@mcbarton, https://github.com/compiler-research/ci-workflows

I've made you maintainer and you should be able to do almost everything.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Dec 4, 2024
@mcbarton mcbarton added to-fix and removed stale labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI workflows to-fix
Projects
None yet
Development

No branches or pull requests

3 participants