Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change html dependency to download through https, instead of ssh #7

Open
rajashekar2014 opened this issue Jun 11, 2018 · 5 comments
Open

Comments

@rajashekar2014
Copy link

rajashekar2014 commented Jun 11, 2018

https://github.com/colynb/gulp-html-prettify/blob/master/package.json

Package Json: "html": "git://github.com/colynb/commonjs-html-prettyprinter.git".

This is causing UI build failure on jenkins slave, where ssh external access is restricted.

@matteobucci
Copy link

I'm having the same issue with travis. Is there any workaround?

@matejsp
Copy link

matejsp commented Oct 23, 2019

Any update on this issue?

@revelt
Copy link
Collaborator

revelt commented Oct 23, 2019

@colynb please amend, it's a tiny quick update

@cniesen
Copy link

cniesen commented Nov 2, 2021

This issue and urgency has become a bit bigger as GitHub is retiring the git:// protocol.
https://github.blog/2021-09-01-improving-git-protocol-security-github/

@revelt
Copy link
Collaborator

revelt commented Nov 2, 2021

I forgot this issue still exists, I've just checked, I'm not using this package any more. For posterity, if you look for well-maintained alternatives, it depends what you want to prettify. Industry standard is prettier, so if your HTML is pure and doesn't break prettier's parsers, that's the solid way. To use prettier (any arbitrary string-in string-out function), use gulp-tap, I have posted examples for email-comb how it can be done. If we go further, if HTML is not pure, the only tool I know (and use) is manual, the tabifier — that website just keeps on giving, I've been using it for like 10 years. tabifier's algorithm is really solid. Having said that, the challenge exists the opposite way, to minify (or rather prepare for production), for which again, it depends what you're minifying: if it's a web page with pure HTML, Kangax minifier is industry-standard; if it's an email template, especially HTML mixed with templating tags, check out email-comb from your's truly. Takeaway: you might not need this package at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants