switch to old school approach for the async manager loosing scope in UDFs

Author: jclausen

models/AmazonS3.cfc

@@ -832,33 +832,54 @@ component accessors="true" singleton {
 				}
 				try {
 
-					function processPart( part ){
-						var channel = part.channel.position( part.offset );
-						var buffer  = createObject( "java", "java.nio.ByteBuffer" ).allocate( part.limit );
-						channel.read( buffer );
-
-						return {
-							"partNumber" : part.partNumber,
-							"size"       : part.limit,
-							"channel"    : part.channel,
-							"response"   : s3Request(
-								method     = "PUT",
-								resource   = bucketName & "/" & uri,
-								body       = buffer.array(),
-								timeout    = part.timeout,
-								parameters = {
-									"uploadId"   : part.uploadId,
-									"partNumber" : part.partNumber
-								},
-								headers = { "content-type" : "binary/octet-stream" }
-							)
-						};
-					}
-					// Alow for using outside of `box` context
-					if( structKeyExists( variables, "asyncManager" ) ){
-						parts = variables.asyncManager.allApply( parts, processPart );
+					// We have to do this manually due to the async manager losing scope when we use it as a UDF
+					// TODO: Move this to a function and pass in the all of the args used
+					if( !isNull( variables.asyncManager ) ){
+						parts = variables.asyncManager.allApply( parts, function( part ){
+							var channel = part.channel.position( part.offset );
+							var buffer  = createObject( "java", "java.nio.ByteBuffer" ).allocate( part.limit );
+							channel.read( buffer );
+
+							return {
+								"partNumber" : part.partNumber,
+								"size"       : part.limit,
+								"channel"    : part.channel,
+								"response"   : s3Request(
+									method     = "PUT",
+									resource   = bucketName & "/" & uri,
+									body       = buffer.array(),
+									timeout    = part.timeout,
+									parameters = {
+										"uploadId"   : part.uploadId,
+										"partNumber" : part.partNumber
+									},
+									headers = { "content-type" : "binary/octet-stream" }
+								)
+							};
+						} );
 					} else {
-						parts = parts.map( processPart );
+						parts = parts.map(  function( part ){
+							var channel = part.channel.position( part.offset );
+							var buffer  = createObject( "java", "java.nio.ByteBuffer" ).allocate( part.limit );
+							channel.read( buffer );
+
+							return {
+								"partNumber" : part.partNumber,
+								"size"       : part.limit,
+								"channel"    : part.channel,
+								"response"   : s3Request(
+									method     = "PUT",
+									resource   = bucketName & "/" & uri,
+									body       = buffer.array(),
+									timeout    = part.timeout,
+									parameters = {
+										"uploadId"   : part.uploadId,
+										"partNumber" : part.partNumber
+									},
+									headers = { "content-type" : "binary/octet-stream" }
+								)
+							};
+						} );
 					}
 
 					var finalizeBody = "<?xml version=""1.0"" encoding=""UTF-8""?><CompleteMultipartUpload xmlns=""http://s3.amazonaws.com/doc/2006-03-01/"">";