Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala.js #186

Open
ForNeVeR opened this issue Aug 15, 2016 · 14 comments
Open

Update Scala.js #186

ForNeVeR opened this issue Aug 15, 2016 · 14 comments
Assignees

Comments

@ForNeVeR
Copy link
Member

This is surprisingly complex task until we've done migration from Play framework. I have done some initial work in feature/frontend, but currently I cannot build it with fullOptJS because of some Play+RhinoJS inconsistencies. Maybe we'll revisit this branch later.

@rexim
Copy link
Member

rexim commented Aug 15, 2016

I'd say that it's kind of extracted from #185

@ForNeVeR
Copy link
Member Author

That's another approach to #161 I've tried before creating #185. Now it's a separate task.

@hagane
Copy link

hagane commented Aug 19, 2016

@ForNeVeR I would like to help. Could you elaborate on the issues you encountered? And on the rationale behind the whole "migration from Play" thing, for that matter -- looks like there's no outstanding issues regarding it.

@ForNeVeR
Copy link
Member Author

There're no issues, but the whole milestone full of various ideas. Maybe it'd be better to first come up with some vision of our new platform.

@hagane
Copy link

hagane commented Aug 19, 2016

I'd like to respectfully ostracize the very idea of performing a near-total redevelopment of the website, especially considering that some sick bastards well-adjusted gentlepeople happen to peruse it. We have a CTOR rewrite-from-scratch in the works, how about trying the whole finagle shebang there first? It's stalling hard anyway, so the cost of eventual potential failure would be negligible.

@ForNeVeR
Copy link
Member Author

ForNeVeR commented Aug 19, 2016

We have a CTOR rewrite-from-scratch in the works, how about trying the whole finagle shebang there first?

That's why nobody is rewriting loglist actively. Wanna to participate? You're welcome. Wanna criticize? You're welcome in the corresponding issues.

Regarding Scala.js — tomorrow at the morning I'll describe the exact issue I was having while trying to enable fullOptJs there.

@hagane
Copy link

hagane commented Aug 19, 2016

Right. Meanwhile I'll accept the invitation and go criticize.

@ForNeVeR
Copy link
Member Author

ForNeVeR commented Aug 20, 2016

Regarding the issue: I've rebased feature/frontend on top of the current master (i.e. after using fullOptJS in build), and now it's getting the following error:

java.lang.NoSuchMethodError: com.google.javascript.rhino.Node.setStaticSourceFile(Lcom/google/javascript/rhino/StaticSourceFile;)V

I have no exact idea what's happening there, but I have a suspicion that it have something to do with the installed Rhino and/or Play versions.

@ForNeVeR
Copy link
Member Author

See #187.

@hagane
Copy link

hagane commented Aug 20, 2016

I've come to conclusion that the primary cause is that org.scala-js:sbt-scalajs migrated from org.mozilla:rhino to io.apogee:rhino somewhere in 0.6.x. But org.mozilla:rhino is still transitively pulled by com.typesafe.play:sbt-plugin So far I've been able to persuade sbt to use one single version of Rhino, but the build still fails with the same error with any one of them.

The solutions still untried are:

  • Scrap the whole "update all the things" initiative in favor of eventual reimplementation (that's a whole 'nother can of worms);
  • Try updating Play to, like, 2.5.x;
  • Split the codebase into separate sbt builds and use something cool to orchestrate the ur-build.

@ForNeVeR
Copy link
Member Author

I'd start from updating Play.

@Minoru
Copy link
Member

Minoru commented Oct 15, 2020

This is superseded by #225, which updates Scala.js to 1.2.0 (amongst other things).

@Minoru Minoru closed this as completed Oct 15, 2020
@Minoru
Copy link
Member

Minoru commented Oct 15, 2020

Wait, I thought I'm closing the PR that tried to update Scala.js >_< Reopen, reopen until someone noticed!

@Minoru Minoru reopened this Oct 15, 2020
@ForNeVeR ForNeVeR self-assigned this Oct 18, 2020
@Minoru
Copy link
Member

Minoru commented Oct 25, 2020

JFYI, #225 updated Scala.js to then-current 1.2.0, but the 1.3.0 is out now, so this can't be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants