Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .plate for footer #167

Open
ForNeVeR opened this issue May 6, 2016 · 6 comments
Open

Add .plate for footer #167

ForNeVeR opened this issue May 6, 2016 · 6 comments

Comments

@ForNeVeR
Copy link
Member

ForNeVeR commented May 6, 2016

Currently footer looks so lonely on some of the pages :(

I think we should add class="plate" for it. Something like that:

image

But:

  • fix the vertical align (one of the toughest problems in CSS ever)

  • right padding

  • restyle that RSS icon maybe? I'm thinking about something like that but no so shitty as in my pic:
    image

    The point is that is should have zero padding and be integral part of our "plate" line.

@ForNeVeR
Copy link
Member Author

ForNeVeR commented May 6, 2016

/summon @rexim @Minoru

What would you guys say?

@Minoru
Copy link
Member

Minoru commented May 6, 2016

If you put the footer onto a plate, there will be a number of negative consequences:

  • the plate will draw unnecessary attention to the footer;
  • since page links aren't on a plate, they will become a bit obscure;
  • the end of the page won't be much different from the contents of the page, which is… bad style, I guess. I don't have anything to back this one up, though (other than my taste).

I vote either not to change anything, or to put both page links and footer onto plates (two separate ones). This, at least, will give the page consistency in style.

@ForNeVeR
Copy link
Member Author

ForNeVeR commented May 6, 2016

I guess you haven't seen how footer looks on new quote page. Just look at this! http://loglist.net/quote/new

But yeah, we really should think about placing the page links to a plate or highlighting them in some another way.

@Minoru
Copy link
Member

Minoru commented May 6, 2016 via email

@ForNeVeR
Copy link
Member Author

ForNeVeR commented May 6, 2016

Also it doesn't look too bad even if we highlight only the footer. Check the visual of this:

https://dl.dropboxusercontent.com/u/10908547/plate.png

(Sorry, I am not able to insert the image due to some network problems at the moment.)

@Minoru
Copy link
Member

Minoru commented May 6, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants