Skip to content
This repository has been archived by the owner on Jun 13, 2019. It is now read-only.

add pagination to /admin/stats page #39

Open
championswimmer opened this issue May 19, 2017 · 6 comments
Open

add pagination to /admin/stats page #39

championswimmer opened this issue May 19, 2017 · 6 comments

Comments

@championswimmer
Copy link
Contributor

this is for frontend. first solve #38 so that the api gives data in pages. then solve this.

@thenamankumar
Copy link
Contributor

@championswimmer won't infinite scroll be better? As OneAuth also have to get integrated and users will have separate login, we will have to again update the API accordingly.

Infinite Scroll will be just front end work and we will not have to serve multiple pages, though dynamic, to a single user.

@abhishek97
Copy link
Contributor

@hereisnaman infinite scroll is nice. But i think the infinite scroll should be backed by an api similar to pagination so that the scroll "streams" data from backend on the fly rather that getting everything at once and then scroll-ify it.

@thenamankumar
Copy link
Contributor

thenamankumar commented May 30, 2017

@abhishek97 yeah if we need that it pulls content from backend with every load more trigger, rather than pulling all content at once, then arrangements in the API are needed.

Then if we go with that thing, I still, as a user, would like a to have an infinite scroll because I don't want to browse through multiple pages, searching my link.

What you say ?

@thenamankumar
Copy link
Contributor

@abhishek97 I mean pulling only limited content at once, can we just do it infinite scroll way, than pagination :) ?

@abhishek97
Copy link
Contributor

Yes we can make infinite scroll with the current api as well. Let's have an infinite scroll

@thenamankumar
Copy link
Contributor

@abhishek97 Great! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants