Skip to content

Commit

Permalink
Revise patch 5062194
Browse files Browse the repository at this point in the history
The previous solution broke test doc_docKeepsScroll.
  • Loading branch information
marijnh committed Mar 15, 2013
1 parent db62428 commit 9338ba4
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/codemirror.js
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ window.CodeMirror = (function() {
}
updateSelection(cm);
updateScrollbars(cm.display, cm.doc.height);
cm.doc.scrollTop = cm.display.scroller.scrollTop;

return updated;
}
Expand Down Expand Up @@ -1271,8 +1270,10 @@ window.CodeMirror = (function() {
var coords = cursorCoords(cm, doc.sel.head);
newScrollPos = calculateScrollPos(cm, coords.left, coords.top, coords.left, coords.bottom);
}
if (op.changes.length || newScrollPos && newScrollPos.scrollTop != null)
if (op.changes.length || newScrollPos && newScrollPos.scrollTop != null) {
updated = updateDisplay(cm, op.changes, newScrollPos && newScrollPos.scrollTop);
if (cm.display.scroller.offsetHeight) cm.doc.scrollTop = cm.display.scroller.scrollTop;
}
if (!updated && op.selectionChanged) updateSelection(cm);
if (op.updateScrollPos) {
display.scroller.scrollTop = display.scrollbarV.scrollTop = doc.scrollTop = newScrollPos.scrollTop;
Expand Down

0 comments on commit 9338ba4

Please sign in to comment.