Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a modular JAR add the module descriptors directly to the archive instead of storing them in a temp location first #98

Closed
plamentotev opened this issue Sep 15, 2018 · 0 comments
Assignees
Milestone

Comments

@plamentotev
Copy link
Member

plamentotev commented Sep 15, 2018

In order to update the module descriptors in a modular JAR file we're using the JDK jar tool but it requires files to be added to the JAR file in order the update to work. We know that a modular JAR file contains one or more module-info.class files (otherwise it is not a modular JAR) so we initially store them in temporary location and later use them to update the JAR file using the jar tool.

It turns out adding just empty directory to the JAR file works as well. So lets add all module-info.class files directly to the JAR file and after that update it using an empty temporary directory.

That would fix #97 as well.

@plamentotev plamentotev added this to the 3.7.0 milestone Sep 15, 2018
@plamentotev plamentotev self-assigned this Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant