addressing PR comments and clean up

Co-authored-by: Arin Choi <[email protected]>

Author: anisharamnani

app/lib/efile/md/md502_su_calculator.rb

@@ -3,7 +3,7 @@ module Md
     class Md502SuCalculator < ::Efile::TaxCalculator
       attr_reader :lines, :value_access_tracker
 
-      CODE_LETTERS = ["AB", "U"]
+      CALCULATED_FIELDS_AND_CODE_LETTERS = { MD502_SU_LINE_AB: "AB", MD502_SU_LINE_U: "U" }
 
       def initialize(value_access_tracker:, lines:, intake:)
         @value_access_tracker = value_access_tracker

app/lib/pdf_filler/md502_pdf.rb

@@ -161,16 +161,11 @@ def check_box_if_x(value)
     end
 
     def generate_codes_for_502_su
-      calculated_fields_code_letters = {
-        MD502_SU_LINE_AB: "ab",
-        MD502_SU_LINE_U: "u",
-        MD502_SU_LINE_V: "v"
-      }
       applicable_codes = []
 
       if calculated_fields.fetch(:MD502_SU_LINE_1).positive?
-        calculated_fields_code_letters.each do |calculated_field, code_letter|
-          applicable_codes << code_letter if calculated_fields.fetch(calculated_field).to_i.positive?
+        Efile::Md::Md502SuCalculator::CALCULATED_FIELDS_AND_CODE_LETTERS.each do |calculated_field, code_letter|
+          applicable_codes << code_letter.downcase if calculated_fields.fetch(calculated_field).to_i.positive?
         end
       end
       applicable_codes

app/lib/submission_builder/ty2024/states/md/documents/md502_su.rb

@@ -11,12 +11,11 @@ class Md502Su < SubmissionBuilder::Document
             def document
               build_xml_doc("Form502SU", documentId: "Form502SU") do |xml|
                 xml.Subtractions do |subtractions|
-                  Efile::Md::Md502SuCalculator::CODE_LETTERS.each do |code_letter|
-                    code_letter_calculation = "MD502_SU_LINE_#{code_letter}".to_sym
-                    if calculated_fields.fetch(code_letter_calculation).positive?
+                  Efile::Md::Md502SuCalculator::CALCULATED_FIELDS_AND_CODE_LETTERS.each do |calculated_field, code_letter|
+                    if calculated_fields.fetch(calculated_field).positive?
                       subtractions.OtherDetail do |other_detail|
                         other_detail.Code code_letter.upcase
-                        other_detail.Amount calculated_fields.fetch(code_letter_calculation)
+                        other_detail.Amount calculated_fields.fetch(calculated_field)
                       end
                     end
                   end

spec/lib/submission_builder/ty2024/states/md/documents/md502_su_spec.rb

@@ -13,7 +13,7 @@
     describe ".document" do
       context "Subtractions" do
         context "individual code letter tests" do
-          Efile::Md::Md502SuCalculator::CODE_LETTERS.each do |code_letter|
+          Efile::Md::Md502SuCalculator::CALCULATED_FIELDS_AND_CODE_LETTERS.values.each do | code_letter|
             code_letter_sym = "calculate_line_#{code_letter}".to_sym.downcase
 
             context "when the #{code_letter} subtraction is present" do
@@ -42,12 +42,12 @@
 
         context "multiple code letters" do
           before do
-            Efile::Md::Md502SuCalculator::CODE_LETTERS.each do |code_letter|
-              allow_any_instance_of(Efile::Md::Md502SuCalculator).to receive("calculate_line_#{code_letter}".to_sym.downcase).and_return(100)
+            Efile::Md::Md502SuCalculator::CALCULATED_FIELDS_AND_CODE_LETTERS.values.each do |code_letter|
+              allow_any_instance_of(Efile::Md::Md502SuCalculator).to receive("calculate_line_#{code_letter}".downcase.to_sym).and_return(100)
             end
           end
 
-          Efile::Md::Md502SuCalculator::CODE_LETTERS.each_with_index do |code_letter, i|
+          Efile::Md::Md502SuCalculator::CALCULATED_FIELDS_AND_CODE_LETTERS.values.each_with_index do |code_letter, i|
             it "outputs the XML for code #{code_letter.downcase}" do
               expect(xml.search("Form502SU Subtractions OtherDetail Code")[i].text).to eq(code_letter)
               expect(xml.search("Form502SU Subtractions OtherDetail Amount")[i].text.to_i).to eq(100)

spec/models/state_file_md_intake_spec.rb

@@ -283,6 +283,7 @@
         create(
           :state_file1099_r,
           taxable_amount: 1_000,
+          recipient_ssn: intake.primary.ssn,
           intake: intake)
       }
       let!(:state_file_md1099_r_followup_with_military_service_for_primary_1) do
@@ -310,7 +311,7 @@
         create(
           :state_file_md1099_r_followup,
           service_type: "none",
-          state_file1099_r: create(:state_file1099_r, taxable_amount: 1_000, intake: intake)
+          state_file1099_r: create(:state_file1099_r, taxable_amount: 1_000, intake: intake, recipient_ssn: intake.spouse.ssn)
         )
       end