[Self-hosted] [Regression] External links to GitHub Enterprise are broken on 24.11.1/rolling

[nikosatwork]

Describe the bug
External links to GitHub Enterprise are broken again on 24.11.1/rolling

Note: CODECOV_GHE_HOST is set correctly

Environment (please complete the following information):

• Browser: Any
• System: UI
• Version: 24.11.1, rolling

To Reproduce
Steps to reproduce the behavior:

1. Go to any commit in Commits tab or pull request in Pulls tab
2. Click on the external commit link or pull request link at the top
3. Land on broken URL i.e.
   https://codecov.self-hosted.com/ghe/org/repo/commit/undefined/org/repo/commit/20af0b22f0bb50a29045d0df51ea1de8097535a1
   instead of
   https://github.cds.self-hosted.com/org/repo/commit/20af0b22f0bb50a29045d0df51ea1de8097535a1
   , where CODECOV_GHE_HOST = https://github.cds.self-hosted.com

Expected behavior
Land on
https://github.enterprise.com/org/repo/commit/20af0b22f0bb50a29045d0df51ea1de8097535a1
, when CODECOV_GHE_HOST = https://github.cds.self-hosted.com

[nikosatwork]

Hi @drazisil-codecov. This is broken again in latest version :(

[RulaKhaled]

Update here:
We didn’t make any changes in Gazebo related to external commit/pull links, but the issue appeared in the recent build. This issue does not occur in our self-hosted version where the links are working as expected. I noticed that we replace config.GHE_BASE with CODECOV_GHE_HOST in docker/start-nginx.sh with this script:

sed -i -r "s/r.[a-zA-Z]+.GHE_URL/"${GHE_SCHEME_BASE}://${GHE_BASE}"/g" /var/www/app/gazebo/assets/*.js

@nikosatwork confirmed they set GHE_SCHEME_BASE correctly, i wonder if something went wrong during the asset build process that prevented the ${GHE_BASE} variable from being replaced correctly, i'll tag infra to see how we can move forward with this.

[RulaKhaled]

@codecov/infrastructure

[drazisil-codecov]

@RulaKhaled Is codecov/gazebo@848db44#diff-e497e731da86cf12cec75cbaa4821a398354dab8b7126fcd28ce98cb6f4a716b possibly related?

[RulaKhaled]

I don't think so, if the new type is wrong it would've failed on all instances

[RulaKhaled]

@katia-sentry can we hand this one off to infra/platform? this is related to building the image, the code is fine.

[katia-sentry]

@trent-codecov putting this on the infra board to take a look at this issue.

[nikosatwork]

Hi team. Thank you for looking at this issue. It is quite fantamental that we get this "quality of life" feature back, where you can move between Codecov and Github seamlessly; and get a little more trust in the tool from the developers using it daily. Thank you 🙏