Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in patch version 3.1.5 #1230

Closed
eashwar opened this issue Jan 25, 2024 · 6 comments
Closed

Breaking change in patch version 3.1.5 #1230

eashwar opened this issue Jan 25, 2024 · 6 comments

Comments

@eashwar
Copy link

eashwar commented Jan 25, 2024

Hi all, the change from 3.1.4 to 3.1.5 updates the runtime of the action to Node.js 20.

This is a breaking change for runners that do not support node 20 but are using @v3 as the tag for the action.

Tooling at my company was broken since we use @v3 but are still in progress rolling out node 20 support for our self-hosted runners -- thus, our core CI pipeline started to fail with the release of 3.1.5.

A breaking change to the runtime of a reusable GHA workflow should be semantically versioned as a new major version, not a new patch version like it was. Can we either rollback this change and re-roll it out as a 4.0 change, or at least moving forward make sure we properly respect semantic versioning?

@cliffchapmanrbx
Copy link

+1, our GHES instance is not using the latest version and can't make use of a GHA runner that fully supports Node 20. We're manually pinning to 3.1.4 in our workflows now to avoid this unexpected change.

We'd really like to see a 3.1.6 pushed that reverts this unexpected dependency change, and instead roll the Node 20 version update into the v4 beta alongside the other breaking changes you're planning.

Other GitHub Actions that we use from other vendors generally chose a major version bump when updating the required NodeJS version which prevented unexpected issues. We've generally trained our engineers to use @v3 in their actions instead of @main to avoid these types of surprises and that's prevented issues with other vendors updating things.

@thomasrockhu-codecov
Copy link
Contributor

@eashwar @cliffchapmanrbx apologies, this was done as node16 was being deprecated. I will push out a fix in the next hour to revert the change and move to 3.1.6

@thomasrockhu-codecov
Copy link
Contributor

This has been remedied in 3.1.6. Sorry for the delay here

@cliffchapmanrbx
Copy link

That's exactly what we were hoping for, thank you for addressing it quickly! We'll keep pressing on with our GHA runner upgrade process :)

@sebastianbergmann
Copy link

When can we expect a v4 release? I'd like to get rid of the "Node.js 16 actions are deprecated" warning :) Thanks!

@thomasrockhu-codecov
Copy link
Contributor

@sebastianbergmann in about an hour!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants