Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global prepareBaseImage not working #88

Closed
fsblemos opened this issue Jul 29, 2021 · 5 comments
Closed

Global prepareBaseImage not working #88

fsblemos opened this issue Jul 29, 2021 · 5 comments

Comments

@fsblemos
Copy link
Contributor

Hi!

After this change, the global prepareBaseImage is not generating the base images. It's only working when passing to seeVisualDiff.

I'm opening a PR to fix it, can you take a look?

Thanks for you work
@fsblemos fsblemos mentioned this issue Jul 29, 2021
Closed
@stracker-phil stracker-phil mentioned this issue Aug 9, 2021
Merged
@puneet0191
Copy link
Member

thanks a lot for reporting, I will look at the PR's

@puneet0191
Copy link
Member

@fsblemos could you help test #90 has some refactoring and also fixes the issue you reported.

@fsblemos
Copy link
Contributor Author

Thank you @puneet0191! #90 looks great and solves this issue! I can close #89 then

@puneet0191
Copy link
Member

thanks a lot for checking, I really appreciate it.

@puneet0191 puneet0191 mentioned this issue Aug 10, 2021
Merged
@puneet0191
Copy link
Member

Releasing with the fix thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix global prepareBaseImage fsblemos/codeceptjs-resemblehelper
2 participants
@puneet0191 @fsblemos