Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed control not working on the new BBC iPlayer #214

Open
jeenuv opened this issue Sep 14, 2023 · 5 comments
Open

Speed control not working on the new BBC iPlayer #214

jeenuv opened this issue Sep 14, 2023 · 5 comments

Comments

@jeenuv
Copy link

jeenuv commented Sep 14, 2023 •
edited
Loading

For example: https://www.bbc.com/news/av/world-africa-66787997.

The keyboard shortcuts don't work. The speed control overlay isn't displayed, either.

I'm on Firefox.
@gabmifre
Copy link

I am also having this issue on Firefox. It seemed to happen after updating to the most recent version of Firefox. When I go to the settings for the extension, there are no saved settings and they are not saved when I go back to the settings page.

@gabmifre
Copy link

When I check Firefox debugger I get this error: "TypeError: storage is undefined"

@gabmifre
Copy link

It seems that there is already permission for storage in the manifest.json. The issue is likely that <link rel="manifest" href="manifest.json" /> is not in the html files which is needed according to this. If this line is added to the <head></head> it may fix it. I can't figure out how to edit the extension code, so maybe someone else can.

@markygnlg
Copy link

I found this at the bottom of the settings:

"Extension controls not appearing?

This extension is only compatible with HTML5 audio and video. If you don't see the controls showing up, chances are you are viewing a Flash content. If you want to confirm, try right-clicking on the content and inspect the menu: if it mentions flash, then that's the issue. That said, most sites will fallback to HTML5 if they detect that Flash is not available. You can try manually disabling Flash from the browser. "

... and also:

" Regex is supported.
Be sure it is in "//g" format.
ie: /(.+)youtube.com(/*)$/gi " (I don't know what that means)

@jeenuv
Copy link
Author

jeenuv commented Jan 8, 2024

BBC iPlayer videos are indeed HTML5. I don't think there are websites that play flash videos anymore.

The Regex mention is for sites on which the extension should be disabled, so is not relevant for this issue.

That said, I had a quick glance: I noticed that the video element for BBC iPlayer are nestled in the shadow DOM. Maybe that's why it's escaping from the purview of the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeenuv @markygnlg @gabmifre