Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #95562 - backupccl: explicitly parse SHOW BACKUP options #16146

Open
cockroach-teamcity opened this issue Jan 28, 2023 · 2 comments
Open

PR #95562 - backupccl: explicitly parse SHOW BACKUP options #16146

cockroach-teamcity opened this issue Jan 28, 2023 · 2 comments

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 28, 2023

Exalate commented:

Related PR: cockroachdb/cockroach#95562
Commit: cockroachdb/cockroach@e6f47a0


Release note (sql change): Previously, SHOW BACKUP options would get parsed as
kv_options, which meant that a user could not pass multiple values to a show
backup option, causing feature gaps in SHOW BACKUP relative to BACKUP and
RESTORE. This patch rewrites the show backup option parser, closing the
following feature gaps: 1. A user can now pass and check multiple KMS URIs in
SHOW BACKUP 2. A user can pass locality aware incremental_locations, allowing a
user to also pass the check_files parameter to a locality aware backup chain
that also specifies the backup incremental location.

Note that while this patch introduces a couple new words to the CRDB SQL
syntax, the same SHOW BACKUP options should remain documented, specifically:

  • [public option] -> value
  • AS_JSON -> N/A
  • CHECK_FILES -> N/A
  • INCREMENTAL_LOCATION -> string, with potentially multiple uris
  • DEBUG_IDS -> N/A
  • KMS -> string, with potentially multiple uris
  • PRIVILEGES -> N/A
  • ENCRYPTION_PASSPHRASE -> string

Jira Issue: DOC-6703

@exalate-issue-sync
Copy link

Mike Lewis (mikeCRL) commented:
Routed to Disaster Recovery based on cockroach package https://cockroachlabs.atlassian.net/wiki/spaces/ED/pages/2934931562/Routing+issues+to+Product+Areas

@exalate-issue-sync exalate-issue-sync bot assigned ashleykwtam and unassigned katmayb Mar 16, 2023
@exalate-issue-sync
Copy link

Kathryn Hancox (kathancox) commented:
Let’s create an example here to combine some of these options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants