From 51a879c16866e7f4d049c2d4e3ad9a8df6288237 Mon Sep 17 00:00:00 2001 From: Raphael 'kena' Poss Date: Mon, 19 Apr 2021 17:03:55 +0200 Subject: [PATCH] server: skip TestTelemetrySQLStatsIndependence This test flakes if the reg server is temporarily unavailable. Release note: None --- pkg/server/stats_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkg/server/stats_test.go b/pkg/server/stats_test.go index 71e00b4a20ce..836efaae972d 100644 --- a/pkg/server/stats_test.go +++ b/pkg/server/stats_test.go @@ -27,6 +27,7 @@ import ( "github.com/cockroachdb/cockroach/pkg/sql/tests" "github.com/cockroachdb/cockroach/pkg/testutils" "github.com/cockroachdb/cockroach/pkg/testutils/serverutils" + "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/util/leaktest" "github.com/cockroachdb/cockroach/pkg/util/log" "github.com/cockroachdb/cockroach/pkg/util/timeutil" @@ -37,6 +38,12 @@ import ( func TestTelemetrySQLStatsIndependence(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) + + // This test fails if the central reporting server from CRL + // breaks. It should be improved to customize the reporting URL and + // mock the registration collector with an in-memory server. + skip.WithIssue(t, 63851) + ctx := context.Background() params, _ := tests.CreateTestServerParams() s, sqlDB, _ := serverutils.StartServer(t, params)