roachtest: update hibernate blacklist for SFU #41101
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @rafiss)
pkg/cmd/roachtest/hibernate_blacklist.go, line 195 at r1 (raw file):
"org.hibernate.test.immutable.entitywithmutablecollection.noninverse.EntityWithNonInverseOneToManyJoinTest.testOneToManyCollectionOptimisticLockingWithUpdate": "5807", "org.hibernate.test.immutable.entitywithmutablecollection.noninverse.VersionedEntityWithNonInverseOneToManyJoinTest.testOneToManyCollectionOptimisticLockingWithUpdate": "5807", "org.hibernate.test.insertordering.InsertOrderingWithCascadeOnPersist.testInsertOrderingAvoidingForeignKeyConstraintViolation": "6583",
This test didn't pass in the nightly run because it was not run, so I guess we should not be removing it yet.
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/hibernate_blacklist.go, line 96 at r1 (raw file):
"org.hibernate.test.annotations.naturalid.ImmutableNaturalKeyLookupTest.testSubCriteriaOneToOneJoin": "6583", "org.hibernate.test.annotations.onetoone.hhh9798.OneToOneJoinTableTest.storeNonUniqueRelationship": "5807", "org.hibernate.test.annotations.query.QueryAndSQLTest.testNativeQueryWithFormulaAttributeWithoutAlias": "unknown",
This one is the 39th test that actually passed. https://github.com/hibernate/hibernate-orm/blob/5e8781f8fa123d4e437f669b57cfa1456a169873/hibernate-core/src/test/java/org/hibernate/test/annotations/query/QueryAndSQLTest.java#L97-L106 the test is actually marked as "FailureExpected."
We never removed expected failures from the hibernate tests after adding SFU parsing. Release justification: test-only change Release note: None
jordanlewis
force-pushed
the
hibernate
branch
from
0f76f56 to
bde54bd
Compare
There was a problem hiding this comment.
Thanks for the careful review!
bors r+
Reviewable status:
pkg/cmd/roachtest/hibernate_blacklist.go, line 96 at r1 (raw file):
Previously, yuzefovich wrote…
This one is the 39th test that actually passed. https://github.com/hibernate/hibernate-orm/blob/5e8781f8fa123d4e437f669b57cfa1456a169873/hibernate-core/src/test/java/org/hibernate/test/annotations/query/QueryAndSQLTest.java#L97-L106 the test is actually marked as "FailureExpected."
Done. wow, you really reviewed this carefully. Thank you.
pkg/cmd/roachtest/hibernate_blacklist.go, line 195 at r1 (raw file):
Previously, yuzefovich wrote…
This test didn't pass in the nightly run because it was not run, so I guess we should not be removing it yet.
Good point... nice catch, done.
41101: roachtest: update hibernate blacklist for SFU r=jordanlewis a=jordanlewis We never removed expected failures from the hibernate tests after adding SFU parsing. Release justification: test-only change Release note: None Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
We never removed expected failures from the hibernate tests after adding
SFU parsing.
Release justification: test-only change
Release note: None