ui: Debug Page Flashes #23428
Merged
ui: Debug Page Flashes #23428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two debug pages (Localities and Raft Ranges) were flashing content while refreshing data; this is because they were using the wrong criteria for determing whether to display a "loading..." message instead of content. Fixes cockroachdb#23411 Fixes cockroachdb#21700 Release note: None
|
This change is |
couchand
approved these changes
Mar 5, 2018
There was a problem hiding this comment.
Looks fine, though it's worth noting that @a-robinson had suggested that the raft ranges page not auto-refresh at all.
Probably cherry-pick?
|
I don't particularly care whether it auto-refreshes, I just didn't want it to bump me up to the top of the page every time it did. Thanks @mrtracy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two debug pages (Localities and Raft Ranges) were flashing content while
refreshing data; this is because they were using the wrong criteria for
determing whether to display a "loading..." message instead of content.
Fixes #23411
Fixes #21700
Release note: None