From 11882491d6a960263e9549f99e746fc55ed17062 Mon Sep 17 00:00:00 2001 From: Herko Lategan Date: Fri, 8 Mar 2024 09:33:51 +0000 Subject: [PATCH] roachprod: use logger for `printDetails` A recent update to PrintDetails redirected output to `os.Stdout`, it should preferably write to the logger, in order for it to end up in the correct log when used with `roachtest`. This change points it to `logger.Stdout` instead. See: #119763 Epic: None Release Note: None --- pkg/roachprod/cloud/cluster_cloud.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/roachprod/cloud/cluster_cloud.go b/pkg/roachprod/cloud/cluster_cloud.go index 7d196d2f17db..b3e389375049 100644 --- a/pkg/roachprod/cloud/cluster_cloud.go +++ b/pkg/roachprod/cloud/cluster_cloud.go @@ -14,7 +14,6 @@ import ( "bytes" "context" "fmt" - "os" "regexp" "sort" "text/tabwriter" @@ -180,7 +179,7 @@ func (c *Cluster) PrintDetails(logger *logger.Logger) error { logger.Printf("(no expiration)") } // Align columns left and separate with at least two spaces. - tw := tabwriter.NewWriter(os.Stdout, 0, 8, 2, ' ', 0) + tw := tabwriter.NewWriter(logger.Stdout, 0, 8, 2, ' ', 0) logPrettifiedHeader(tw, printDetailsColumnHeaders) for _, vm := range c.VMs {