Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: set COCKROACH_TESTING_FORCE_RELEASE_BRANCH only when necessary #99127

Open
renatolabs opened this issue Mar 21, 2023 · 1 comment
Open
Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. quality-friday A good issue to work on on Quality Friday T-testeng TestEng Team

Comments

@renatolabs
Copy link
Contributor

renatolabs commented Mar 21, 2023

In, #97595, we started setting COCKROACH_TESTING_FORCE_RELEASE_BRANCH in clusters created with roachprod. That is not ideal because:

  • is not standard behavior that customers would encounter
  • can be confusing, especially if you are trying to upgrade a cluster created with a version of roachprod that predated that change
  • makes it harder to reuse disk images that were created before this change.

We should:

  • not be setting any of COCKROACH_TESTING_FORCE_RELEASE_BRANCH or COCKROACH_UPGRADE_TO_DEV_VERSION by default on roachprod clusters
  • only set COCKROACH_TESTING_FORCE_RELEASE_BRANCH in upgrade-related roachtests. Unfortunately this will involve some manual work to figure out which tests are going to need to change due to the ad-hoc nature of roachtest and the lack of a unified API.

Jira issue: CRDB-25713

@renatolabs renatolabs added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure T-testeng TestEng Team labels Mar 21, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 21, 2023

cc @cockroachdb/test-eng

@tbg tbg added the quality-friday A good issue to work on on Quality Friday label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. quality-friday A good issue to work on on Quality Friday T-testeng TestEng Team
Projects
None yet
Development

No branches or pull requests

2 participants