Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: users should have control over histogram granularity for connection latencies #96000

Open
dhartunian opened this issue Jan 26, 2023 · 0 comments
Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability

Comments

@dhartunian
Copy link
Collaborator

dhartunian commented Jan 26, 2023

Issues like #95833 have made clear that a static histogram bucket list may always produce confusing outcomes. On the other hand, an extremely large set of buckets creates performance problems for customers who are ingesting histograms via prometheus.

One possible implementation is to keep separate histograms for Prometheus output, and more granular hdrhistogram-based ones for computing internal percentiles. The latter should remain quite accurate, while the former could be more coarse to enable easier Grafana use by customers.

This problem is not limited to just connection latencies, but is most easily visible in that particular metric.

Jira issue: CRDB-23890

@dhartunian dhartunian added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability-inf labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability
Projects
None yet
Development

No branches or pull requests

1 participant