Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemachanger: Deprecate is_nullable in ColumnType element #95893

Open
Xiang-Gu opened this issue Jan 26, 2023 · 1 comment
Open

schemachanger: Deprecate is_nullable in ColumnType element #95893

Xiang-Gu opened this issue Jan 26, 2023 · 1 comment
Labels
A-schema-changer-impl Related to the implementation of the new schema changer C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Jan 26, 2023

This issue is opened to track the deprecation process for is_nullable in ColumnType element.
The context here is that we changed the element modeling in V23_1 to handle NOT NULL constraint
of a column. We thus need to consider mixed version compatibility. This issue exists therefore to
track the deprecation process as we move into future major releases.

Jira issue: CRDB-23797

@Xiang-Gu Xiang-Gu added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Jan 26, 2023
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Jan 26, 2023
@Xiang-Gu
Copy link
Contributor Author

Xiang-Gu commented Jan 26, 2023

The current plan, which might age out, is to do the following in V23_2:

  • Delete is_nullable from ColumnType;
  • Stop using ColumnType.elementCreationMetadata in scmutationexec

@postamar postamar added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-schema-changer-impl Related to the implementation of the new schema changer and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Jan 31, 2023
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-schema-changer-impl Related to the implementation of the new schema changer C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

2 participants