Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: flake in TestChangeReplicasGeneration #95351

Closed
Tracked by #98672
knz opened this issue Jan 17, 2023 · 3 comments
Closed
Tracked by #98672

kv: flake in TestChangeReplicasGeneration #95351

knz opened this issue Jan 17, 2023 · 3 comments
Assignees
@erikgrinaker
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered).

Comments

@knz
Copy link
Contributor

knz commented Jan 17, 2023 •
edited by cockroach-jira-scripts
Loading

Found here: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_BazelEssentialCi/8343686?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true

Failed
=== RUN   TestChangeReplicasGeneration
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/d220ac54548e03726afbc72442fd0656/logTestChangeReplicasGeneration891072375
    test_log_scope.go:79: use -show-logs to present logs inline
    client_replica_test.go:2647: unexpected error: cannot remove learner while snapshot is in flight
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/d220ac54548e03726afbc72442fd0656/logTestChangeReplicasGeneration891072375
--- FAIL: TestChangeReplicasGeneration (1.57s)

cc @erikgrinaker for triage.

Jira issue: CRDB-23471
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). A-kv-replication Relating to Raft, consensus, and coordination. T-kv-replication labels Jan 17, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jan 17, 2023

cc @cockroachdb/replication

@blathers-crl blathers-crl bot added the T-kv KV Team label Jan 17, 2023
@knz knz mentioned this issue Jan 17, 2023
Merged
@andreimatei
Copy link
Contributor

Happened also in TestLearnerOrJointConfigAdminRelocateRange:
https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_UnitTests_BazelUnitTests/8345618?showRootCauses=false&expandBuildChangesSection=true&expandBuildTestsSection=true&expandBuildProblemsSection=true

@erikgrinaker erikgrinaker self-assigned this Jan 18, 2023
@erikgrinaker erikgrinaker removed the T-kv KV Team label Jan 18, 2023
@kvoli kvoli mentioned this issue Mar 15, 2023
Closed
4 tasks
@erikgrinaker
Copy link
Contributor

Going to close this out as stale. There's some work to improve the general problem of cannot remove learner while snapshot is in flight in #98672 and #99099.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andreimatei @knz @erikgrinaker