Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: cockroach mt start-sql does not support the --locality-advertise-addr argument #90172

Closed
knz opened this issue Oct 18, 2022 · 3 comments
Closed
Labels
A-server-networking Pertains to network addressing,routing,initialization A-server-start-drain Pertains to server startup and shutdown sequences C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-server-and-security DB Server & Security

Comments

@knz
Copy link
Contributor

knz commented Oct 18, 2022

Describe the problem

For KV node-node connections, we support a --locality-advertise-addr that tells nodes to use different hostnames to connect to other nodes depending on their locality. This enables customizing which addresses are exposed in k8s in each region.

For multi-region serverless support, we'll need a similar mechanism for communication between SQL-only servers.

However, currently the --locality-advertise-addr flag is not supported by SQL-only servers. It probably should.

Might relate to #52266
Might relate to #42741

Jira issue: CRDB-20621

@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-server-networking Pertains to network addressing,routing,initialization A-server-start-drain Pertains to server startup and shutdown sequences labels Oct 18, 2022
@blathers-crl blathers-crl bot added the T-server-and-security DB Server & Security label Oct 18, 2022
@knz
Copy link
Contributor Author

knz commented Oct 18, 2022

cc @jeffswenson for consideration

@jeffswenson
Copy link
Collaborator

The --locality-advertise-addr is not needed by Multi Region Serverless. We set up the VPC so that each region has a unique ip range and regions are able to route to each other via the internal ip address.

Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-server-networking Pertains to network addressing,routing,initialization A-server-start-drain Pertains to server startup and shutdown sequences C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-server-and-security DB Server & Security
Projects
No open projects
Status: Done 21.2
Development

No branches or pull requests

3 participants