Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: improve how regions information is collected for telemetry #88498

Closed
yuzefovich opened this issue Sep 22, 2022 · 2 comments
Closed

sql: improve how regions information is collected for telemetry #88498

yuzefovich opened this issue Sep 22, 2022 · 2 comments
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Sep 22, 2022

#86829 added the regions information into the telemetry. In order to minimize the changes and to make the commit backportable it relied on the existing infrastructure used for the EXPLAIN output to get the regions information. This is a bit hacky (e.g. #88343 had to make additional changes to not break things), so we should refactor this since there is no reason to force building the EXPLAIN output when it's only needed to get the regions information output. We should instead analyze the flow specifications (we have "save flows" function for that) after the physical planning has been performed and store the regions information in the instrumentation helper. Care needs to be taken to not introduce any performance impact since getAllNodeDescriptors might have non-trivial overhead.

Jira issue: CRDB-19945

@yuzefovich yuzefovich added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. labels Sep 22, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Sep 22, 2022
@mgartner mgartner moved this to Backlog (DO NOT ADD NEW ISSUES) in SQL Queries Jul 24, 2023
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@yuzefovich
Copy link
Member Author

This actually has been addressed, I think by #106587

@github-project-automation github-project-automation bot moved this from Backlog (DO NOT ADD NEW ISSUES) to Done in SQL Queries Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

No branches or pull requests

1 participant