Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: collect log-based telemetry on regions visited by each query #85427

Closed
rytaft opened this issue Aug 1, 2022 · 2 comments · Fixed by #86829
Closed

sql: collect log-based telemetry on regions visited by each query #85427

rytaft opened this issue Aug 1, 2022 · 2 comments · Fixed by #86829
Assignees
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team

Comments

@rytaft
Copy link
Collaborator

rytaft commented Aug 1, 2022

Is your feature request related to a problem? Please describe.
Currently our log-based telemetry does not include the regions visited by a query. It would be helpful to know how many of our customers' queries are visiting multiple regions.

Describe the solution you'd like
The log-based telemetry should include all the regions visited by a query, similar to the region information currently output by EXPLAIN ANALYZE. Although the EXPLAIN ANALYZE output today doesn't technically include every region touched by the query (e.g., if the KV api fetches data from a remote region this will not be represented), it will give us a pretty good idea. In particular, it will include all the regions where DistSQL processors are planned.

Describe alternatives you've considered
It would be helpful to include regions visited by the KV api, but this would be a more invasive change.

Jira issue: CRDB-18243

@rytaft rytaft added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 1, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Aug 1, 2022
@rytaft
Copy link
Collaborator Author

rytaft commented Aug 1, 2022

cc @awoods187

@awoods187
Copy link
Contributor

cc @vy-ton for awareness as I'm out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants