Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/catalog/tabledesc,upgrade: migrate away invalid sequence references #83124

Closed
ajwerner opened this issue Jun 21, 2022 · 3 comments · Fixed by #86255
Closed

sql/catalog/tabledesc,upgrade: migrate away invalid sequence references #83124

ajwerner opened this issue Jun 21, 2022 · 3 comments · Fixed by #86255
Assignees
@Xiang-Gu
Labels
branch-master Failures and bugs on the master branch. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Jun 21, 2022 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.

Bugs in 21.1 and prior sometimes added sequence references which had the 0 column ID. We should migrate those away.

Describe the solution you'd like
Write a migration to repair these references.

Additional context
See #82576.

Jira issue: CRDB-16874
@ajwerner ajwerner added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jun 21, 2022
@ajwerner ajwerner mentioned this issue Jun 21, 2022
Merged
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Jun 21, 2022
@ajwerner ajwerner mentioned this issue Jun 27, 2022
Closed
@ajwerner ajwerner added branch-master Failures and bugs on the master branch. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jun 28, 2022
@ajwerner
Copy link
Contributor Author

This needs to be done before the end of the release but it's not urgent. It should leverage the machinery being added in #82172. I'm tentatively assigning Xiang with that background. The release-blocker label is just to make sure we don't forget.

@Xiang-Gu
Copy link
Contributor

@ajwerner I will happily take this.
We need to write an upgrade, so I guess it will be similar to #81583 (not #82172)?

@ajwerner
Copy link
Contributor Author

Correct

@Xiang-Gu Xiang-Gu mentioned this issue Aug 16, 2022
Merged
@craig craig bot closed this as completed in db1554b Aug 26, 2022
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiang-Gu Xiang-Gu

Labels
branch-master Failures and bugs on the master branch. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
2 participants
@ajwerner @Xiang-Gu