Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.*: Audit cases where the sstable Writer is closed twice #75749

Open
bananabrick opened this issue Jan 31, 2022 · 1 comment
Open

.*: Audit cases where the sstable Writer is closed twice #75749

bananabrick opened this issue Jan 31, 2022 · 1 comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@bananabrick
Copy link
Contributor

bananabrick commented Jan 31, 2022 •
edited by cockroach-jira-scripts
Loading

We've seen some cases where the sstable writer is closed twice:

See,
#75717
#75687
#75691

We maintain a property in the Writer that a call to Writer.Close is idempotent. However, it will be cleaner to audit the cases where Close can be called more than once, and get rid of them.

Jira issue: CRDB-12814
@bananabrick bananabrick added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 31, 2022
@bananabrick bananabrick changed the title Audit cases where the sstable Writer is closed twice .*: Audit cases where the sstable Writer is closed twice Jan 31, 2022
@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as completed Sep 4, 2023
@bananabrick bananabrick reopened this Sep 4, 2023
@github-actions github-actions bot removed the X-stale label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bananabrick