Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql,descpb: remove descpb.MaybeFixPrivileges #61070

Closed
postamar opened this issue Feb 24, 2021 · 1 comment
Closed

sql,descpb: remove descpb.MaybeFixPrivileges #61070

postamar opened this issue Feb 24, 2021 · 1 comment
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@postamar
Copy link

... or at the very least, only ever call it in descriptor constructors like NewMaybeFilledInMutable.

Currently, this function is called in descriptor validation methods. Validation methods shouldn't mutate the descriptor. In fact, ideally, nothing should, unless it's an explicit method on a Mutable type like SetPrimaryIndex or whatever.
@postamar postamar added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-schema-descriptors Relating to SQL table/db descriptor handling. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Feb 24, 2021
@postamar postamar mentioned this issue Feb 24, 2021
Merged
@postamar
Copy link
Author

Addressed by #61429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@postamar