distsql: change join reader batch size to be specified in bytes #39471
Labels
A-sql-execution
Relating to SQL execution.
C-performance
Perf of queries or internals. Solution not expected to change functional behavior.
Milestone
A prior version of this issue had this description:
This has already been done in the index joiner (commit message from #38622):
However the join reader is different because it is not guaranteed that there is a 1:1 relationship between lookup and result rows. #38614 tracked the addition of information for when this is the case, so we should use this to conditionally increase the join reader batch size in those cases.
Updated issue
The idea is the same but the KV interface now allows us to specify a
TargetBytes
for the results. This means that we can increase the batch size (or even change it to bytes) for lookups where the equality columns do not form a key. Unfortunately, usingTargetBytes
in the key case means that the lookup requests won't be parallelized, so we'll have to evaluate this tradeoff.The text was updated successfully, but these errors were encountered: