Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: descriptor acquisition waits for in-flight lease acquisition unnecessarily #18851

Closed
andreimatei opened this issue Sep 27, 2017 · 2 comments
Closed

sql: descriptor acquisition waits for in-flight lease acquisition unnecessarily #18851

andreimatei opened this issue Sep 27, 2017 · 2 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@andreimatei
Copy link
Contributor

cockroach/pkg/sql/lease.go

Line 592 in 4a23ce1

t.acquireWait()

The misnamed tableState.acquire() is given a timestamp and asked to return a descriptor valid for that timestamp. It invariably waits for any in-flight lease acquisitions, even if the timestamp is below the frontier at which leases are needed.
@andreimatei andreimatei added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Sep 27, 2017
@andreimatei
Copy link
Contributor Author

cc @vivekmenezes

@andreimatei andreimatei mentioned this issue Sep 27, 2017
Closed
@lgo
Copy link
Contributor

lgo commented Dec 18, 2017

This was fixed by #19005

@lgo lgo closed this as completed Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreimatei @lgo