Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: prune unneeded dependencies #18789

Closed
couchand opened this issue Sep 26, 2017 · 2 comments
Closed

ui: prune unneeded dependencies #18789

couchand opened this issue Sep 26, 2017 · 2 comments
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. no-issue-activity X-stale

Comments

@couchand
Copy link
Contributor

Every byte of dependency counts against us twice: it bloats our binary size in addition to the usual concerns about bandwidth to the client & parse-execute time. We should make sure every dependency we include is necessary (and then make the admin UI load as quick as possible, see #18668). NVD3 is our second-biggest dependency, and we already have an issue to eliminate that - #18620. Let's evaluate the rest of our dependencies and make sure they all add enough value to justify including.

screen shot 2017-09-26 at 12 15 05 pm

@couchand
Copy link
Contributor Author

In particular, it looks like a number of our dev dependencies are getting pulled into the bundle (I noticed chai, css-loader, and some typings). After #18349 lands, we should check again to see if we can update the webpack config to prevent this.

@couchand couchand added this to the 1.2 milestone Sep 26, 2017
@couchand couchand modified the milestones: 2.0, Later Jan 29, 2018
@couchand couchand added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. labels Apr 24, 2018
@petermattis petermattis removed this from the Later milestone Oct 5, 2018
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. no-issue-activity X-stale
Projects
None yet
Development

No branches or pull requests

2 participants