Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distsql: distSQLReceiver should respond to context cancellation #15671

Closed
andreimatei opened this issue May 3, 2017 · 1 comment
Closed

distsql: distSQLReceiver should respond to context cancellation #15671

andreimatei opened this issue May 3, 2017 · 1 comment
Assignees
@andreimatei
Milestone
1.1

Comments

@andreimatei
Copy link
Contributor

It's unclear to me what happens now in case the context of a distsql query is cancelled on the gateway. The distSQLReceiver doesn't respond to that in any way. RPCs using that context should be interrupted, and that's supposed to have cascading effects, but generally distsql RPCs are initiated by the producer, so I think in most cases no RPC will fail when the ctx on the gateway is cancelled.
@andreimatei andreimatei added this to the 1.1 milestone May 3, 2017
@RaduBerinde RaduBerinde mentioned this issue May 3, 2017
Closed
18 tasks
@andreimatei
Copy link
Contributor Author

This has been done in #17870 - the distSQLReceiver is now being signaled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreimatei andreimatei

Labels
None yet
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@andreimatei