Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distsql: ObservedTimestamps are not marshalled back to the gateway #15013

Closed
andreimatei opened this issue Apr 17, 2017 · 1 comment
Closed

distsql: ObservedTimestamps are not marshalled back to the gateway #15013

andreimatei opened this issue Apr 17, 2017 · 1 comment
Assignees
@andreimatei
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Milestone
2.0

Comments

@andreimatei
Copy link
Contributor

The timestamps observed by TableReaders and such on remote nodes are not marshalled backed to the gateway. In the non-distsql world, this happens through Transaction.Update, which uses updated protos from all the BatchResponses.

The consequence is that a transaction can be starved by continuous writers because there's no longer a bound on its uncertainty interval.
@andreimatei andreimatei added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Apr 17, 2017
@andreimatei andreimatei added this to the 1.1 milestone Apr 17, 2017
@andreimatei andreimatei self-assigned this Apr 17, 2017
@RaduBerinde RaduBerinde mentioned this issue Apr 17, 2017
Closed
18 tasks
@andreimatei andreimatei modified the milestones: 1.2, 1.1 Aug 11, 2017
@andreimatei andreimatei added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Aug 11, 2017
@andreimatei andreimatei mentioned this issue Feb 23, 2018
Merged
@spencerkimball
Copy link
Member

Fixed in #21447; the sender's AugmentTxnMeta call used by the distSQL receiver on the TxnCoordMeta propagated from distSQL processors properly builds up the set of all observed timestamps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreimatei andreimatei

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@andreimatei @spencerkimball