Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle: presence of custom zone configs breaks recreation #123904

Closed
yuzefovich opened this issue May 9, 2024 · 1 comment · Fixed by #137584
Closed

bundle: presence of custom zone configs breaks recreation #123904

yuzefovich opened this issue May 9, 2024 · 1 comment · Fixed by #137584
Assignees
@yuzefovich
Labels
A-sql-debug-bundle Issues related to statement bundle improvements branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented May 9, 2024 •
edited by cockroach-jira-scripts
Loading

In the bundles here, we have custom zone configs which breaks debug sb recreate command. I think we should consider commenting those ALTER stmts in schema.sql.

Jira issue: CRDB-38594
@yuzefovich yuzefovich added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. A-sql-debug-bundle Issues related to statement bundle improvements labels May 9, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries May 9, 2024
@yuzefovich yuzefovich moved this from Triage to Backlog in SQL Queries May 9, 2024
@yuzefovich yuzefovich added the T-sql-queries SQL Queries Team label May 10, 2024
@yuzefovich yuzefovich self-assigned this Dec 17, 2024
@yuzefovich yuzefovich moved this from Backlog to Active in SQL Queries Dec 17, 2024
@yuzefovich yuzefovich mentioned this issue Dec 17, 2024
Merged
@craig craig bot closed this as completed in 8e24b34 Dec 18, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Dec 18, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Dec 18, 2024

Based on the specified backports for linked PR #137584, I applied the following new label(s) to this issue: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 labels Dec 18, 2024
This was referenced Dec 18, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
A-sql-debug-bundle Issues related to statement bundle improvements branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: avoid invalid SQL in raw_config_sql in crdb_internal.zones yuzefovich/cockroach
1 participant
@yuzefovich